Use SCSS import vs sprockets require for compatibility with bourbon #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Redactor-Rails Maintainers,
I ran into an issue with my Rails 4 app (but could happen to 3.2 users as well). Instead of using sprockets
requires, files in my application.css, as recommended by Thoughtbot's Bourbon project I use SCSS's@importfeature and rename my applicaton.css to application.css.scss.When I tried to import redactor-rails stylesheets, I got unreadable errors (I think because it uses sprockets inline which vanilla SCSS can't read), so I changed everything over to normal scss imports which work fine. I believe this should be backwards compatible with anyone sprockets so the README.md will not have to change.
Let me know what this needs to merge.